Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: C#12 primary constructors support #720

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat: C#12 primary constructors support #720

merged 1 commit into from
Sep 14, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Sep 5, 2023

Support C#12 primary constructors

Description

Adds support for C#12 primary constructors.
Depends on #718. Probably await .NET 8.0 RC1.

Fixes #684

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@latonz latonz self-assigned this Sep 5, 2023
@latonz latonz changed the title feat: Support C#12 primary constructors feat: C#12 primary constructors support Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #720 (2221c03) into main (c2f1f4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         201      201           
  Lines        6628     6628           
  Branches      821      821           
=======================================
  Hits         6052     6052           
  Misses        387      387           
  Partials      189      189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz marked this pull request as ready for review September 14, 2023 06:48
@latonz latonz enabled auto-merge (squash) September 14, 2023 06:48
@latonz latonz requested a review from ni507 September 14, 2023 06:48
@latonz latonz removed the request for review from ni507 September 14, 2023 06:51
ni507
ni507 previously approved these changes Sep 14, 2023
@latonz latonz merged commit b54b9a5 into riok:main Sep 14, 2023
17 checks passed
@latonz latonz deleted the feat-csharp12-primary-ctor branch September 14, 2023 07:03
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# 12 primary constructor support
2 participants