Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle internal visibility correctly #597

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix: handle internal visibility correctly #597

merged 1 commit into from
Jul 27, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jul 27, 2023

Handle internal visibility correctly

Description

Handles internal visibility including InternalsVisibleTo correctly and maps internal members if possible.

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@latonz latonz self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #597 (f33de83) into main (0ccc734) will decrease coverage by 0.32%.
Report is 1 commits behind head on main.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   90.64%   90.33%   -0.32%     
==========================================
  Files         173      174       +1     
  Lines        5925     5980      +55     
  Branches      757      761       +4     
==========================================
+ Hits         5371     5402      +31     
- Misses        395      410      +15     
- Partials      159      168       +9     
Files Changed Coverage Δ
...uilders/NewInstanceObjectPropertyMappingBuilder.cs 91.17% <0.00%> (ø)
...apperly/Descriptors/SimpleMappingBuilderContext.cs 97.67% <ø> (ø)
src/Riok.Mapperly/Helpers/SymbolExtensions.cs 82.89% <ø> (-3.84%) ⬇️
.../Descriptors/MappingBuilders/SpanMappingBuilder.cs 78.99% <33.33%> (-1.01%) ⬇️
src/Riok.Mapperly/Symbols/PropertyMember.cs 81.25% <50.00%> (+1.25%) ⬆️
src/Riok.Mapperly/Helpers/CompilationExtensions.cs 54.28% <54.28%> (ø)
src/Riok.Mapperly/Descriptors/SymbolAccessor.cs 95.58% <80.76%> (-3.54%) ⬇️
...y/Descriptors/Enumerables/CollectionInfoBuilder.cs 96.63% <81.25%> (-0.92%) ⬇️
...bjectFactories/GenericSourceTargetObjectFactory.cs 95.23% <88.88%> (-0.22%) ⬇️
...s/BuilderContext/MembersContainerBuilderContext.cs 100.00% <100.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz marked this pull request as ready for review July 27, 2023 08:31
@latonz latonz requested a review from ni507 July 27, 2023 08:39
@latonz latonz merged commit 5d4596a into riok:main Jul 27, 2023
13 of 15 checks passed
@latonz latonz deleted the fix/handle-internal-correctly branch July 27, 2023 09:26
latonz added a commit that referenced this pull request Aug 2, 2023
BREAKING CHANGE: Include accessible internal and private members in mappings
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This PR is included in version 3.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants