Refactor PlayOrResumeOptions
#204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinukkusu
approved these changes
Feb 20, 2024
|
@hayribakici please check the conflicts, then I will merge it :) |
|
I don't see any conflicts here 🤔 |
|
What the heck, it told me I couldn't merge because of conflicts. Now it says it's fine on my side, too. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the json attributes of the
PlayOrResumeOptionsmust be disjointed, two new classes have been implemented to keep unnecessary attributes out of the request body. This is the consequence of #202.Furthermore, in order to test
PUT,POSTorDELETEhttp methods, a very rudiment interceptor has been added.