Skip to content

Refactors duplicate logic of list methods #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2023
Merged

Refactors duplicate logic of list methods #169

merged 2 commits into from
Sep 18, 2023

Conversation

hayribakici
Copy link
Collaborator

This PR refactors the logic of the list methods that are in numerous endpoint files. This is done by adding a generic _listWithIds method, which results having less repetetive code.

rinukkusu
rinukkusu approved these changes Sep 18, 2023
View reviewed changes
Copy link
Owner

@rinukkusu rinukkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was contemplating for a second if _listFromIds would fit better, but it's fine 😆

Thank you for your continued contributions! Much appreciated!

@rinukkusu rinukkusu merged commit a99c15b into rinukkusu:master Sep 18, 2023
@hayribakici
Copy link
Collaborator Author

Was contemplating for a second if _listFromIds would fit better, but it's fine 😆

Thank you for your continued contributions! Much appreciated!

That seems like a good idea. Should I change it?

@hayribakici hayribakici deleted the code_cleanup_list branch October 23, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinukkusu rinukkusu rinukkusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayribakici @rinukkusu