Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market integration 2 #166

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Market integration 2 #166

merged 3 commits into from
Sep 18, 2023

Conversation

hayribakici
Copy link
Collaborator

This PR adds the Market enum into Album and Show Model with the availableMarkets member (as discussed in #164). It furthermore changes some signatures, where country is involved.
It also adds some refactoring by renaming some methods with the Market parameter and deprecating the ones with the String parameter.

And finally, I figured, that the method Albums.getTracks was never tested, so I added another test for that.

@hayribakici hayribakici requested a review from rinukkusu May 8, 2023 17:18
@rinukkusu rinukkusu merged commit 45235db into rinukkusu:master Sep 18, 2023
@hayribakici hayribakici deleted the market_integration_2 branch September 18, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinukkusu rinukkusu rinukkusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayribakici @rinukkusu