-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements markets
endpoint
#161
Conversation
Not a big fan of the What would be the gain of such a class? |
Pretty much abstraction and preventing errors when handling with country codes, just as we use the |
@rinukkusu I changed the result-type to an BundledPages get(
String searchQuery, {
Iterable<SearchType> types = SearchType.all,
Market? market,
}) {... Of course I can change it, when you still think it is unnecessary. 😆 |
Hi, sorry for being MIA - I was on vacation 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR implements the
v1/markets
endpoint. In order to prevent errors as such, the country codes are stored in anenum