Relax checkMesonPython() for lang/python/tool.mk
#5
Conversation
When lang/python/tool.mk is included and PYTHON_FOR_BUILD_ONLY is not set it defaults to `tool` and that should be fine for most meson use cases. Stop warning in such cases.
|
(I've also set reviewers and assignees, if that's not okay please also let me know! Thanks!) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 66 66
Lines 20663 20663
=======================================
Hits 20404 20404
Misses 223 223
Partials 36 36 ☔ View full report in Codecov by Sentry. |
|
For possible further information... I have noticed that while working on:
...on I think that in the warning we should also suggest Thank you! |
iamleot
changed the title
checkMesonPython() for lang/python/tool.mk
|
Your change looks perfect, thank you for all the work you've put into it. I don't mind whether you suggest |
|
I will do that in a separate PR then! Feel free to merge if that's okay for you and/or let me know if I can «Rebase and merge» or similar! Thank you Roland! |
#7 does that. |
rillig
deleted the
it-is-okay-to-include-lang-python-toolsmk-and-not-define-python-for-build-only
branch
When
lang/python/tool.mkis included andPYTHON_FOR_BUILD_ONLYis not set it defaults totooland that should be fine for mostmesonuse cases.Stop warning in such cases.
NOTE: this is probably the first non-dependabot PR here. If any possible other way to contribute is preferred please let me know and I will share it elsewhere! Thank you!