-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update scaling policy #5187
Conversation
9198a25
to
6c61aae
Compare
return false | ||
} | ||
|
||
// TODO: Skip scaling for manually assigned slots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@begelundmuller Not quite sure how to figure the slots that is specified by "manual intervene".
OR if is possible/necessary to have a new method for the DB connect
struct to find the info from the Database?
Would you have some recommendations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you would need to add a column with a flag in the database. Or use an annotation to indicate it (such as has_sla
or something else – the annotation could be automatically added if a user calls rill project edit --prod-slots ...
).
@begelundmuller, following some discussions with the infra team, we've decided to temporarily disable down-scaling. Regarding the disabling of scaling for manually-specified slots, I have left a comment seeking further assistance. Concerning the cap at 20%, I am guessing that temporarily disabling down-scaling may suffice for our needs. Additionally, I'm wondering about the |
// Temproray disable scale DOWN - Tony | ||
if recommendSlots <= originSlots { | ||
return false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this configurable through some property/env vars?
A 20% cap (or similar) should only apply to downscaling. Upscaling should not have a cap since it might scale too slowly then. Since you disabled downscaling, this doesn't really matter right now.
You can ask @AndrewRTsao. I think he's the one who is using this annotation. |
As discussed previously, we are using the following tags:
|
- Prevent downscaling
6c61aae
to
4503bbc
Compare
Update:
Should Partially resolve: https://github.com/rilldata/rill-private-issues/issues/475