-
Notifications
You must be signed in to change notification settings - Fork 0
React: Routing and Hooks #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rika-milew
wants to merge
111
commits into
unit-testing
Choose a base branch
from
hooks-and-routing
base: unit-testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
111 commits
Select commit
Hold shift + click to select a range
c824694
refactor: convert button component
rika-milew a94c083
refactor: covert card component
rika-milew a48ea62
refactor: convert error button
rika-milew 7c66d34
refactor: edit error button
rika-milew 99ca4ac
refactor: convert footer
rika-milew 23edf10
refactor: convert header
rika-milew ea713d6
refactor: convert layout
rika-milew a51159b
refactor: refactor loader
rika-milew ba5ae0c
refactor: convert list
rika-milew 41a3ac0
refactor: change use data list
rika-milew d2672fc
refactor: convert pagination and state view
rika-milew e3a021e
feat: add local storage hook
rika-milew 60427a8
refactor: convert search bar
rika-milew 4032a78
refactor: edit list and pagination
rika-milew 3825db2
feat: add tanstack router
rika-milew cad2b29
feat: add header links
rika-milew e2c959c
feat: add about info
rika-milew efd61a8
chore: edit gitignore
rika-milew ccd9c3e
chore: edit path settings
rika-milew 7e92e24
chore: edit configs
rika-milew bf31ea7
chore: edit test setup
rika-milew 1933322
feat: add 404 page
rika-milew 35639bb
feat: add 404 content
rika-milew 069c47c
chore: add import resolver
rika-milew c4f340d
feat: make edit according to review
rika-milew 557b82c
chore: edit pre-push
rika-milew 5e83fcd
chore: edit pre-push
rika-milew 7a512de
chore: add vercel
rika-milew dd79f23
feat: add accessibility
rika-milew 754e564
feat: edit code rabbit comments
rika-milew 50ec569
feat: add error button height
rika-milew 2655720
feat: add visually hidden text for links
rika-milew d8cd449
feat: optimize scroll
rika-milew 25b120d
feat: add header link
rika-milew 36c94d9
feat: edit list
rika-milew 6c64ff9
feat: add spinner accessibility
rika-milew c62533e
feat: edit pagination
rika-milew 7d5a516
feat: add local storage error handling
rika-milew b8dd02f
feat: make edits according to review
rika-milew bddac76
feat: add handle key down on search bar
rika-milew 44049fe
feat: add abort controller
rika-milew 46b9680
feat: edit data service
rika-milew 44c5292
feat: edit styles
rika-milew da73339
feat: edit type guard
rika-milew cfdd497
feat: edit isPokemon
rika-milew cdf396d
feat: add type guards
rika-milew ab7dc77
feat: edit card
rika-milew 0d79a18
chore: add editorconfig
rika-milew e2ebd03
chore: add editorconfig
rika-milew da3a575
feat: edit card test
rika-milew eacc847
feat: edit api tests
rika-milew f01d7a1
feat: edit card classnames
rika-milew 7e835b2
feat: refactor header
rika-milew d9a7bf5
feat: edit header tests
rika-milew 90e22ea
refactor: rename cardlist
rika-milew 060e968
refactor: update list imports
rika-milew 1933056
refactor: loader refactoring
rika-milew 43a1f85
refactor: api function name
rika-milew ec43be4
feat: add status and routes constants
rika-milew dae0f5f
feat: add routetree
rika-milew 2052b09
chore: edit prettier ignore
rika-milew 71e1f96
feat: add prettier ignore to the root
rika-milew 23b2216
feat: add pagination url
rika-milew fe70a8c
feat: add detail outlet
rika-milew 0034635
feat: add outlet
rika-milew 5891992
feat: add click on detail view
rika-milew 3bd122d
feat: edit card types
rika-milew f848192
feat: add card styles
rika-milew 14d5708
feat: edit search page styles
rika-milew cdfc1d6
refactor: move page files
rika-milew b86ec4e
fix: fix styles import
rika-milew 9dc8905
feat: use constants
rika-milew f308b46
fix: fix error boundary
rika-milew 691c601
feat: add tests
rika-milew 4801822
feat: add card config
rika-milew 6df0878
refactor: change styles import order
rika-milew 3ed24f0
fix: fix card option
rika-milew 90f672c
feat: edit loader styles
rika-milew ac03a88
feat: edit classnames
rika-milew 0fc1ac0
chore: add vercel settings
rika-milew d461bb5
feat: add cars font styles
rika-milew 223ec90
feat: change image alt
rika-milew c0ccbcb
feat: edit card tests
rika-milew a42e765
chore: merge vite and vitest configs
rika-milew ed178b7
feat: add api result type
rika-milew 8f8f160
feat: add test to detail view
rika-milew 61d153a
fix: fix code rabbit comments
rika-milew 7e8801d
refactor: raname state view to error state
rika-milew 279221e
fix: change input type
rika-milew 8ef2132
feat: add noopener to links
rika-milew 7e7e557
fix: fix imports
rika-milew 2c2216c
fix: fix search bar tests
rika-milew 8669789
chore: edit comma settings
rika-milew 5d6d6af
feat: change commma format
rika-milew bbe1bfb
refactor: search bar refactoring
rika-milew 427d6ce
refactor: refactor use local storage hook
rika-milew 2934c12
refactor: move local storage tests to search page
rika-milew c5a40a0
refactor: card list and pagination refactoring
rika-milew 13187ae
refactor: use detail refactoring
rika-milew 3c506ea
feat: update tests
rika-milew 1df3841
feat: implement pagination button
rika-milew 9b4c0cc
chore: update eslint config
rika-milew d245153
fix: fix eslint errors
rika-milew b52fcbb
feat: add stylelint config
rika-milew 91a98f9
refactor: rename pagination button
rika-milew 922b0c0
refactor: rename props
rika-milew fc0bc09
refactor: pagination refactoring
rika-milew 770b064
refactor: card list refactoring
rika-milew b821811
refactor: card list and pagination refactoring
rika-milew 8bab15a
fix: fix tests
rika-milew 5fb5ef9
refactor: stylelint fix
rika-milew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #editorconfig.org | ||
| #root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,4 +43,3 @@ out/ | |
|
|
||
| # tests | ||
| coverage/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| node_modules | ||
| dist | ||
| build | ||
| coverage | ||
| routeTree.gen.ts | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| { | ||
| "trailingComma": "es5", | ||
| "trailingComma": "all", | ||
| "tabWidth": 2, | ||
| "semi": true, | ||
| "singleQuote": true | ||
| "singleQuote": true, | ||
| "endOfLine": "lf", | ||
| "insertFinalNewline": true | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.