-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #510: third-party licenses #511
Conversation
|
d8b11ae
to
75c540b
Compare
75c540b
to
80f51be
Compare
e4f8b55
to
bfab1e4
Compare
what's the interest in doing this? Do we expect anyone to care about the readability?
This should be as simple as listing the files in the pyproject.toml
Seems like this might be a release CI step rather than in the MR, right? Things always get a little messy when the MR pipeline commits files back to its branch. Seems like the way to go would be:
Then those artifacts are always up to date for publication and no one has to edit them or wonder if they are supposed to edit them. |
Well, Luke hasn't actually commented on the draft version I sent him back when I first discovered
I think we always want to be able to review changes made by our tooling, and do so before merging to
I mentioned this in slack as well, but |
21b805f
to
f875d47
Compare
d1b910b
to
8c586c4
Compare
I've added it for |
In this PR:
NOTICE
files for Apache-2.0 projects, where presentcargo deny
and Python-publishingTBD, not necessarily in this PR:
THIRDPARTY.yml
file in each MR