Skip to content

Add execution duration to results#1436

Merged
randall-fulton merged 5 commits intorcfrom
query-execution-results
Apr 14, 2022
Merged

Add execution duration to results#1436
randall-fulton merged 5 commits intorcfrom
query-execution-results

Conversation

@randall-fulton
Copy link
Contributor

@randall-fulton randall-fulton commented Apr 13, 2022

Description

Provide additional details on QAMExecutionResult describing the length of time a program held exclusive hardware access while executing.

Checklist

  • The PR targets the rc branch (not master).
  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on the PR's checks.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, Test ignore #1234).

@randall-fulton randall-fulton requested a review from a team as a code owner April 13, 2022 16:13
@randall-fulton randall-fulton marked this pull request as draft April 13, 2022 16:13
@randall-fulton randall-fulton force-pushed the query-execution-results branch from 7dfba39 to d525db3 Compare April 13, 2022 17:21
@randall-fulton randall-fulton marked this pull request as ready for review April 13, 2022 18:12
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 , thanks for the quick work @randall-fulton !

@kalzoo
Copy link
Contributor

kalzoo commented Apr 13, 2022

A follow-up thought - because this is tucked into the API and may not be the most intuitive to find, it may be worth a note in the more human-readable sections that we could then provide as a link to customers - maybe here?

@randall-fulton
Copy link
Contributor Author

@kalzoo Sounds good to me. I was looking for somewhere to do that, but am not super familiar with the layout of the docs and didn't find that particular section.

Will add now.

@randall-fulton randall-fulton merged commit aa4267d into rc Apr 14, 2022
@randall-fulton randall-fulton deleted the query-execution-results branch April 14, 2022 12:54
kalzoo added a commit that referenced this pull request Apr 14, 2022
(Empty commit to trigger semantic release)
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0-rc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants