Skip to content

Update: Assign a fidelity of 100% to RZ operations to break symmetry with RX in ISA. #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbanty merged 3 commits into from
Mar 16, 2022
Merged

Update: Assign a fidelity of 100% to RZ operations to break symmetry with RX in ISA. #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4446a6a
Assign a fidelity of 100% to RZ operations to break symmetry with RX …
Mar 16, 2022
1d15acc
Update test compiler-isa-Aspen-8.json test data
Mar 16, 2022
ae93a30
Update: changelog
Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Changelog
- Function `pyquil.quilatom.substitute()` now supports substitution of classical `MemoryReference`
objects such as `theta[4]` with their parameter values, enabling user-side parameter substitution.
- Versions of `qcs-api-client` up to 0.20.x are now supported.
- The CompilerISA of physical QPUs now assigns a fidelity of 1 to virtual RZs.

### Bugfixes

Expand Down
3 changes: 1 addition & 2 deletions pyquil/quantum_processor/transformers/qcs_isa_to_compiler_isa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,12 @@ def _make_rx_gates(node_id: int, benchmarks: List[Operation]) -> List[GateInfo]:


def _make_rz_gates(node_id: int, benchmarks: List[Operation]) -> List[GateInfo]:
fidelity = _get_frb_sim_1q(node_id, benchmarks)
return [
GateInfo(
operator=Supported1QGate.RZ,
parameters=["_"],
arguments=[node_id],
fidelity=fidelity,
fidelity=PERFECT_FIDELITY,
duration=PERFECT_DURATION,
)
]
Expand Down
60 changes: 30 additions & 30 deletions test/unit/data/compiler-isa-Aspen-8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
0
],
"duration": 0.01,
"fidelity": 0.989821537688075,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -160,7 +160,7 @@
1
],
"duration": 0.01,
"fidelity": 0.996832638579018,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -258,7 +258,7 @@
11
],
"duration": 0.01,
"fidelity": 0.989117848440883,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -351,7 +351,7 @@
12
],
"duration": 0.01,
"fidelity": 0.982010065085791,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -444,7 +444,7 @@
13
],
"duration": 0.01,
"fidelity": 0.994323758479715,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -537,7 +537,7 @@
14
],
"duration": 0.01,
"fidelity": 0.991983796298027,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -630,7 +630,7 @@
15
],
"duration": 0.01,
"fidelity": 0.989822943596874,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -723,7 +723,7 @@
16
],
"duration": 0.01,
"fidelity": 0.988256589534012,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -816,7 +816,7 @@
17
],
"duration": 0.01,
"fidelity": 0.994091587106797,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -909,7 +909,7 @@
2
],
"duration": 0.01,
"fidelity": 0.927538230166735,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1002,7 +1002,7 @@
20
],
"duration": 0.01,
"fidelity": 0.991288110944387,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1095,7 +1095,7 @@
21
],
"duration": 0.01,
"fidelity": 0.992884053396768,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1188,7 +1188,7 @@
22
],
"duration": 0.01,
"fidelity": 0.979355596748001,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1281,7 +1281,7 @@
23
],
"duration": 0.01,
"fidelity": 0.992797468887461,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1374,7 +1374,7 @@
24
],
"duration": 0.01,
"fidelity": 0.988868971757648,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1467,7 +1467,7 @@
25
],
"duration": 0.01,
"fidelity": 0.998004517863263,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1560,7 +1560,7 @@
26
],
"duration": 0.01,
"fidelity": 0.992046520987421,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1653,7 +1653,7 @@
27
],
"duration": 0.01,
"fidelity": 0.998533591062586,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1746,7 +1746,7 @@
3
],
"duration": 0.01,
"fidelity": 0.995159653742827,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1839,7 +1839,7 @@
30
],
"duration": 0.01,
"fidelity": 0.983897042282644,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -1937,7 +1937,7 @@
32
],
"duration": 0.01,
"fidelity": 0.998120225824461,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2030,7 +2030,7 @@
33
],
"duration": 0.01,
"fidelity": 0.997635034524841,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2123,7 +2123,7 @@
34
],
"duration": 0.01,
"fidelity": 0.996864438593304,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2216,7 +2216,7 @@
35
],
"duration": 0.01,
"fidelity": 0.997937749157514,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2309,7 +2309,7 @@
36
],
"duration": 0.01,
"fidelity": 0.990523139563343,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2402,7 +2402,7 @@
37
],
"duration": 0.01,
"fidelity": 0.999999385622736,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2495,7 +2495,7 @@
4
],
"duration": 0.01,
"fidelity": 0.990387707932765,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2588,7 +2588,7 @@
5
],
"duration": 0.01,
"fidelity": 0.996065286885264,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2681,7 +2681,7 @@
6
],
"duration": 0.01,
"fidelity": 0.993098695450792,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down Expand Up @@ -2774,7 +2774,7 @@
7
],
"duration": 0.01,
"fidelity": 0.993901137706895,
"fidelity": 1.0,
"operator": "RZ",
"operator_type": "gate",
"parameters": [
Expand Down