Skip to content

Remove setup.py and dephell#1420

Merged
kalzoo merged 3 commits intorcfrom
fix/remove-dephell
Feb 11, 2022
Merged

Remove setup.py and dephell#1420
kalzoo merged 3 commits intorcfrom
fix/remove-dephell

Conversation

@kalzoo
Copy link
Contributor

@kalzoo kalzoo commented Feb 10, 2022 •
edited
Loading

Description

Dephell has been archived and is no longer maintained. That has been the case for a while but we (Rigetti) have been maintaining a fork since the archive.

The value in doing so is limited, and so now that dephell has broken our build pipelines again, we can just remove this dependency altogether and maintain only pyproject.toml without a conversion to other formats.

Checklist

  • The PR targets the rc branch (not master).
  • Commit messages are prefixed with one of the prefixes outlined in the commit syntax checker (see pattern field).
  • The above description motivates these changes.
  • The changelog is updated, including author and PR number (@username, Test ignore #1234).

@kalzoo kalzoo requested a review from a team as a code owner February 10, 2022 23:24
@kalzoo kalzoo changed the base branch from master to rc February 10, 2022 23:26
dbanty
dbanty suggested changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@dbanty dbanty left a comment •
edited by kalzoo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There's also a section in pyproject.toml which can be removed
  • prepare_release.sh used by semrel needs to have its dephell and setup.py refs removed
  • setup.py asset for semrel in package.json
  • Can remove setup.py exclusion from .flake8

@kalzoo kalzoo force-pushed the fix/remove-dephell branch from d05728b to 6e2bdf4 Compare February 10, 2022 23:38
@kalzoo kalzoo requested a review from dbanty February 10, 2022 23:47
@kalzoo kalzoo changed the title Fix/remove dephell Remove setup.py and dephell Feb 10, 2022
dbanty
dbanty approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kalzoo kalzoo merged commit 05362ee into rc Feb 11, 2022
@kalzoo kalzoo deleted the fix/remove-dephell branch February 11, 2022 00:42
@rigetti-githubbot
Copy link

rigetti-githubbot commented Feb 11, 2022

🎉 This PR is included in version 3.1.0-rc.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dbanty pushed a commit that referenced this pull request Feb 14, 2022
@kalzoo @dbanty
No code: Remove setup.py and dephell (#1420)
3c062ec 
* No code: Remove setup.py and dephell from CI pipeline

* No code: update changelog

* No code: remove setup.py references
@rigetti-githubbot
Copy link

rigetti-githubbot commented Feb 14, 2022

🎉 This PR is included in version 3.2.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rigetti-githubbot
Copy link

rigetti-githubbot commented Aug 3, 2022

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dbanty dbanty dbanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @rc released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kalzoo @rigetti-githubbot @dbanty