Skip to content

Chore: Remove commit checker CI job#1409

Merged
dbanty merged 3 commits intorcfrom
remove-commit-check
Dec 29, 2021
Merged

Chore: Remove commit checker CI job#1409
dbanty merged 3 commits intorcfrom
remove-commit-check

Conversation

@dbanty
Copy link
Contributor

@dbanty dbanty commented Nov 23, 2021

Description

This job is inaccurate for PRs as we squash commits and is not automatically in sync with the eslint rules we currently use (nor will it sync with Angular when we switch).

Checklist

  • The PR targets the rc branch (not master).
  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on the PR's checks.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, Test ignore #1234).

This job is inaccurate for PRs as we squash commits and is not automatically in sync with the eslint rules we currently use (nor will it sync with Angular when we switch).
@dbanty dbanty requested a review from notmgsk November 23, 2021 17:30
@dbanty dbanty requested a review from a team as a code owner November 23, 2021 17:30
@dbanty dbanty merged commit 248bf1b into rc Dec 29, 2021
@dbanty dbanty deleted the remove-commit-check branch December 29, 2021 17:46
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.1.0-rc.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dbanty added a commit that referenced this pull request Feb 14, 2022
* Chore: Remove commit checker CI job

This job is inaccurate for PRs as we squash commits and is not automatically in sync with the eslint rules we currently use (nor will it sync with Angular when we switch).

* Chore: Remove commit syntax instructions from PR template
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants