Skip to content

Upgrade: bump qcs-api-client version#1398

Merged
notmgsk merged 1 commit intorcfrom
update-qcs-api-client
Oct 14, 2021
Merged

Upgrade: bump qcs-api-client version#1398
notmgsk merged 1 commit intorcfrom
update-qcs-api-client

Conversation

@notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Oct 14, 2021

Description

qcs-api-client version 0.12.1 fixes a bug. Because the version restriction was original ^0.8.0 any library that wanted pyquil v3 and qcs-api-client would be restriced to 0.8.x versions.

Checklist

  • The PR targets the rc branch (not master).
  • Commit messages are prefixed with one of the prefixes outlined in the commit syntax checker (see pattern field).
  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on the PR's checks.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, Test ignore #1234).

@notmgsk notmgsk requested a review from a team as a code owner October 14, 2021 18:22
@notmgsk notmgsk force-pushed the update-qcs-api-client branch 2 times, most recently from f997280 to ac5e66e Compare October 14, 2021 18:31
@notmgsk notmgsk force-pushed the update-qcs-api-client branch from ac5e66e to 87a23ef Compare October 14, 2021 21:29
@notmgsk notmgsk force-pushed the update-qcs-api-client branch from 87a23ef to 53cdb54 Compare October 14, 2021 21:31
@notmgsk notmgsk requested a review from dbanty October 14, 2021 21:32
Copy link
Contributor

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One last note: the title of the PR still says Update vs Upgrade. No problem if you're rebasing/merging, but will be the wrong prefix if you squash.

@notmgsk notmgsk changed the title Update: bump qcs-api-client version Upgrade: bump qcs-api-client version Oct 14, 2021
@notmgsk notmgsk merged commit 29a8435 into rc Oct 14, 2021
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.0.2-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dbanty dbanty deleted the update-qcs-api-client branch February 14, 2022 17:03
dbanty pushed a commit that referenced this pull request Feb 14, 2022
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants