Add ability to substitute values for memory references#1385
Merged
Conversation
Contributor
|
@mhodson-rigetti When you have a moment, could you finish the check list and rebase onto |
mhodson-rigetti
force-pushed
the
1383-substitute-memory-references
branch
from
adcf26b to
629a031
Compare
notmgsk
force-pushed
the
1383-substitute-memory-references
branch
from
823097f to
3222392
Compare
…based on `test_eval` for the parameter case.
…n of arrays for the values, and require the user to individually address the values for each memory offset.
…emoryReference`.
notmgsk
force-pushed
the
1383-substitute-memory-references
branch
from
3222392 to
32bba9f
Compare
|
🎉 This PR is included in version 3.1.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.2.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1383 generally as suggested. However, because the identity of a memory reference (as a key- ie. its hash) includes the offset, and substitution is via a map using this key, it was easier to ask the user to address each offset to be substituted individually. Thus, conceptually, the substitution map is
{ x[0]: <number>, x[1]: <number>, x[2]: <number> }for some arrayxof length 3.I'm assuming there are no large-scale performance expectations on this new ability where the array access would make a difference. There is no impact on previous code paths. The alternative would be to use the names (strings) only as the key, but that would technically be a breaking change, where as this PR is not (the key is covariant to the previous
Parameterclass, and now alsoMemoryReference).Checklist
rcbranch (notmaster).patternfield).flake8conventions.