Conversation
| from pyquil.quil import InstructionDesignator, Program | ||
|
|
||
|
|
||
| class ExperimentalProgram(Program): |
Contributor
There was a problem hiding this comment.
Could you not update Program itself? Going from non-optional to optional should be backwards compatible
Contributor
There was a problem hiding this comment.
Though I guess could result in a lot of refactoring to satisfy mypy and other use cases
Contributor
Author
There was a problem hiding this comment.
Part of my intent in this PR is to not have to change anything in the main library for simplicity, with this being almost a "draft" for the next major version (after a long period of iteration & feedback)
Contributor
There was a problem hiding this comment.
That makes good sense 👍
This was referenced Aug 22, 2022
Contributor
Author
|
This work is being superseded by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes needed to incorporate an experimental, gRPC-based client in place of the current
rpcq-based client. These changes would involve breaking changes to the existingQuantumComputerand other interfaces, and due to expected instability, are corralled under theexperimentalsubpackage for flexibility while still making them available to customers.Some features of both gRPC and the new API make the new experimental
QuantumComputerand related classes much simpler. Notably, they are also built withasynciofrom the start.Checklist
rcbranch (notmaster).patternfield).flake8conventions.