Skip to content

New: support engagement against a specified quantum processor endpoint#1342

Merged
kalzoo merged 13 commits intorcfrom
1341-qpu-endpoint
Sep 2, 2021
Merged

New: support engagement against a specified quantum processor endpoint#1342
kalzoo merged 13 commits intorcfrom
1341-qpu-endpoint

Conversation

@kalzoo
Copy link
Contributor

@kalzoo kalzoo commented Jun 16, 2021

Description

This PR adds an endpoint_id argument to both QPU and get_qc, as well as support for engagement-to-endpoint within EngagementManager.

Checklist

  • The PR targets the rc branch (not master).
  • Commit messages are prefixed with one of the prefixes outlined in the commit syntax checker (see pattern field).
  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on the PR's checks.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, Test ignore #1234).

@kalzoo kalzoo changed the base branch from master to rc June 16, 2021 03:43
@kalzoo kalzoo force-pushed the 1341-qpu-endpoint branch from f69e5b1 to 262892b Compare June 16, 2021 05:25
@kalzoo kalzoo requested a review from ameyer-rigetti June 16, 2021 05:41
Copy link
Contributor

@ameyer-rigetti ameyer-rigetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just had some test-related comments.

@kalzoo kalzoo force-pushed the 1341-qpu-endpoint branch from 996e33b to 19bcc19 Compare August 30, 2021 23:17
@kalzoo kalzoo force-pushed the 1341-qpu-endpoint branch from 19bcc19 to fbfc0aa Compare August 30, 2021 23:27
@kalzoo kalzoo requested a review from dbanty August 31, 2021 19:46
Copy link
Contributor

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, most of these are just nitpicks, I'll approve once the commented-out debug statement is cleared.

@kalzoo kalzoo force-pushed the 1341-qpu-endpoint branch from 3520386 to 1d54f11 Compare August 31, 2021 20:59
@kalzoo kalzoo force-pushed the 1341-qpu-endpoint branch from 1816119 to f7abc6f Compare August 31, 2021 22:10
@kalzoo kalzoo force-pushed the 1341-qpu-endpoint branch from f7abc6f to f19acd9 Compare August 31, 2021 22:14
@kalzoo kalzoo marked this pull request as ready for review September 1, 2021 05:37
@kalzoo kalzoo requested a review from a team as a code owner September 1, 2021 05:37
Copy link
Contributor

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@kalzoo kalzoo merged commit d0c4c53 into rc Sep 2, 2021
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.0.1-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dbanty dbanty deleted the 1341-qpu-endpoint branch February 14, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants