New: support engagement against a specified quantum processor endpoint#1342
Merged
New: support engagement against a specified quantum processor endpoint#1342
Conversation
f69e5b1 to
262892b
Compare
ameyer-rigetti
suggested changes
Jun 16, 2021
Contributor
ameyer-rigetti
left a comment
There was a problem hiding this comment.
Implementation looks good, just had some test-related comments.
erichulburd
approved these changes
Jun 16, 2021
996e33b to
19bcc19
Compare
19bcc19 to
fbfc0aa
Compare
dbanty
suggested changes
Aug 31, 2021
Contributor
dbanty
left a comment
There was a problem hiding this comment.
Looks good, most of these are just nitpicks, I'll approve once the commented-out debug statement is cleared.
3520386 to
1d54f11
Compare
dbanty
approved these changes
Aug 31, 2021
1816119 to
f7abc6f
Compare
f7abc6f to
f19acd9
Compare
|
🎉 This PR is included in version 3.0.1-rc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
endpoint_idargument to bothQPUandget_qc, as well as support for engagement-to-endpoint withinEngagementManager.Checklist
rcbranch (notmaster).patternfield).flake8conventions.