Skip to content

Integrate QCS API client#1300

Merged
ameyer-rigetti merged 1 commit intorelease-3.0from
1298-integration_qcs_api_client
Mar 17, 2021
Merged

Integrate QCS API client#1300
ameyer-rigetti merged 1 commit intorelease-3.0from
1298-integration_qcs_api_client

Conversation

@erichulburd
Copy link
Contributor

@erichulburd erichulburd commented Feb 18, 2021

Relates to issue #1298

High-level changes:

  • Replaced PyquilConfig with QCSClientConfiguration. This deprecated all the old env vars, like QVM_URL and QUILC_URL, which are now:
    • QCS_SETTINGS_APPLICATIONS_PYQUIL_QVM_URL
    • QCS_SETTINGS_APPLICATIONS_PYQUIL_QUILC_URL
  • Network calls (including auth/engagements) are all handled by a new class api.Client*
  • Common QVMCompiler and QPUCompiler code moved into existing AbstractCompiler base
  • QVMCompiler now produces a Program instead of PyQuilExecutableResponse. This means that QVM.load() always takes a Program instead of something "compiled" (QVM.requires_executable was also removed as it is moot)
  • Removed deprecated error types (api/_errors.py)
  • Other small refactors and error message cleanup
  • Note: We've decided that in a later PR, we'll refactor the api.Client to be more of a client factory, rather than have it be a do-all client

@erichulburd erichulburd requested a review from a team as a code owner February 18, 2021 22:08
@erichulburd erichulburd mentioned this pull request Feb 18, 2021
31 tasks
@erichulburd erichulburd changed the title add qcs-api-client to dependencies integrate QCS API client Feb 18, 2021
@ameyer-rigetti ameyer-rigetti marked this pull request as draft March 3, 2021 00:32
@ameyer-rigetti ameyer-rigetti changed the title integrate QCS API client Integrate QCS API client Mar 11, 2021
@ameyer-rigetti ameyer-rigetti force-pushed the 1298-integration_qcs_api_client branch from e387b89 to 1a8c0b9 Compare March 12, 2021 23:46
@ameyer-rigetti ameyer-rigetti marked this pull request as ready for review March 12, 2021 23:50
@ameyer-rigetti ameyer-rigetti force-pushed the 1298-integration_qcs_api_client branch 3 times, most recently from 0762d7b to 4eda395 Compare March 13, 2021 00:09
@ameyer-rigetti ameyer-rigetti force-pushed the 1298-integration_qcs_api_client branch from 4eda395 to ae0f337 Compare March 13, 2021 00:09
@notmgsk
Copy link
Contributor

notmgsk commented Mar 17, 2021

When you say some envvars have been deprecated, does that mean they will still continue to work (and potentially emit a warning)?

@ameyer-rigetti
Copy link
Contributor

ameyer-rigetti commented Mar 17, 2021

When you say some envvars have been deprecated, does that mean they will still continue to work (and potentially emit a warning)?

@notmgsk "Deprecated" may have been a poor word choice. They will not longer function and will require the noted prefix.

The changelog words it better.

@notmgsk
Copy link
Contributor

notmgsk commented Mar 17, 2021

When you say some envvars have been deprecated, does that mean they will still continue to work (and potentially emit a warning)?

@notmgsk "Deprecated" may have been a poor word choice. They will not longer function and will require the noted prefix.

Cool. We should make a note of this in any migration documentation.

@ameyer-rigetti
Copy link
Contributor

Cool. We should make a note of this in any migration documentation.

@notmgsk Definitely. Updating docs is in the epic :)

Copy link
Contributor

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress!1!


def validate_qubit_list(qubit_list: Sequence[int]) -> Sequence[int]:
"""
Check the validity of qubits for the payload.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe note what the criteria are

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have mentioned: this and the two functions around it were simply moved over from _base _connection.py, so I don't know a ton about their implementation

@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.0.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rigetti rigetti deleted a comment from rigetti-githubbot Mar 22, 2021
@ameyer-rigetti ameyer-rigetti deleted the 1298-integration_qcs_api_client branch March 22, 2021 14:49
ameyer-rigetti pushed a commit that referenced this pull request May 5, 2021
Authored-by: Andrew Meyer <ameyer@rigetti.com>
kalzoo pushed a commit that referenced this pull request Jun 14, 2021
Authored-by: Andrew Meyer <ameyer@rigetti.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants