Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove else statement that causes schemas to not be set correctly #99

Merged
merged 4 commits into from
Sep 10, 2023

Conversation

survivorbat
Copy link
Contributor

@survivorbat survivorbat commented Aug 9, 2023

Did a few. things, with the removal of the else being the main update.

  • Make tests run in parallel
  • Rename unexported mock properties to better reflect purpose (they aren't caches)
  • Fix existing schemas not loading if a version is given in SetSchema

If you're not interested in the rename or parallel I can remove those changes

@survivorbat
Copy link
Contributor Author

Hey @riferrei, if you find time could you perhaps have a look at this change? :)

@survivorbat
Copy link
Contributor Author

Another improvement: Makes sure Codec's error is returned

@AtakanColak AtakanColak merged commit baa74d8 into riferrei:master Sep 10, 2023
2 checks passed
@AtakanColak
Copy link
Collaborator

Thanks @survivorbat!

@survivorbat survivorbat deleted the bugfix/mock-else branch October 8, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants