Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup of MockRegistryClient #94

Merged
merged 9 commits into from
Oct 24, 2022
Merged

Small cleanup of MockRegistryClient #94

merged 9 commits into from
Oct 24, 2022

Conversation

survivorbat
Copy link
Contributor

@survivorbat survivorbat commented Oct 1, 2022 •
edited
Loading

  • Add a Codec so that you can actually replicate the example
  • Remove unused codecCreationEnabled
  • Change schema := &Schema{} to var schema *Schema because the former can never be nil in the == nil check
  • Update tests to increase coverage and prevent issues like above
  • Change version fetch

Related to #92

@survivorbat survivorbat mentioned this pull request Oct 2, 2022
Closed
@survivorbat
Copy link
Contributor Author

Hey @AtakanColak I updated the pull request with the requested changes :)

@AtakanColak AtakanColak merged commit 961d4d9 into riferrei:master Oct 24, 2022
@AtakanColak
Copy link
Collaborator

Thanks for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtakanColak AtakanColak AtakanColak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@survivorbat @AtakanColak