-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure & handling of the shakyground grid files #4
Restructure & handling of the shakyground grid files #4
Conversation
I also think I will have another check with shellCheck. But I will do this tomorrow. |
By the way, I changed the name of the script, as I think something like Still it is possible to just run the script without any parameters ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving it! Nothing to add here. Can be merged!
These are really up to @bpross-52n and @arnevogt - so they shouldn't keep us from merging this. |
Sounds good to me! |
Unfortunally I can't merge myself (missing permissions). So @MichaelLangbein please merge it today. |
One last thing: I did just a little brainstorming regarding shell scripts vs something similar to docker-compose files. First: I'm not aware if it is actually possible to do all this with docker compose - I just use the subset that I need on a daily basis. However, if I would introduce configurations similar to the way the docker-compose yml files look like I would endup with a subset like this: services:
quakeledger:
image: "gfzriesgos/quakeledger"
before_script:
- "git clone https://github.com/gfzriesgos/quakeledger"
build:
context: "quakeledger"
dockerfile: "metadata/Dockerfile"
tags:
- "latest"
artifacts:
paths:
- "metadata/quakeledger.json"
expose_in: "configs"
deus:
image: "gfzriesgos/deus"
before_script:
- "git clone https://github.com/gfzriesgos/deus"
build:
context: "deus"
dockerfile: "metadata/Dockerfile"
tags:
- "latest"
artifacts:
paths:
- "metadata/deus.json"
- "metadata/volcanus.json"
- "metadata/neptunus.json"
expose_in: "configs"
shakyground_grid:
image: "gfzriesgos/shakyground-grid-file"
before_script:
- "git clone https://github.com/gfzriesgos/shakyground-grid-file"
build:
context: "shakyground-grid-file"
dockerfile: "Dockerfile"
tags:
- "latest"
shakyground:
image: "gfzriesgos/shakyground"
depends_on: shakyground_grid
before_script:
- "git clone https://github.com/gfzriesgos/shakyground"
- "sed -i -e 's/FROM gfzriesgos\/shakyground-grid-file:20211011/FROM gfzriesgos\/skakyground-grid-file:latest/' ./metadata/Dockerfile"
build:
context: "shakyground"
dockerfile: "Dockerfile"
tags:
- "latest"
artifacts:
paths:
- "metadata/shakyground.json"
expose_in: "configs"
While I think this is easier to add/modify for the project partners, I'm not 100% sure if a tool that would be needed to actually do that actions would be reused. (When I currently do something like this, I adjust the dockerfiles - and don't have some before_script, after_script (which I had while brainstorming) or arctifacts. |
By the way: I'm not really a fan of yaml - so I would do that only if it would be really beneficial to do. |
But if we would go that way overall, we could also set all of that up as an gitlab-ci.yml file too (or maybe similar stuff for the github actions). |
I think that would be pretty nifty, too! Actually, this topic is too interesting to leave in this thread - let's discuss this on the next standup or in mattermost! |
This pull request adds the handling of the shakyground grid files & restructures the existing script
The way to handle the grid files is relativly simple:
For the rest, the PR is mainly a bit restructing:
clean
function, so that we can test that all the stuff still works without any effects of our previous steps.I'm sorry that the restructuring is that large, but I hope I'm not the only one who can see that as at least a bit beneficial.
Things still to do (in other pull requests):
Sorry that it took so much time of the day to reach that stage, but my bash-fu is really limited & the problems I had with the shakyground images were super annoying (not super complicated, but error messages after it downloaded the stuff, so it took way to long to try several things out).