Improve event sending thread lifecycle management #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This remove an hypothetical race condition where a Thread is created, start running and raise an expection *before* the main thread sets this Thread's abort_on_exception to true.
If for some reason the worker thread is stopped (this should not happen under normal circumstances), the #drain method called by #at_exit will wait forever for queued items to be consumed. Ensure the worker thread is still running while we drain.
If we cannot communicate with Riemann, assume this is a trancient error, drop the messages and continue processing. Otherwise, terminate the program (without a worker sending thread, it does not make sense to stack events forever).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a bunch of enhancements to the event sender thread to make the system more resilient to transcient communication errors.
When riemann was unreachable,
riemann-wrapperwas terminating, and the other tools stopped trying to send events (even if riemann was reachable again). This is now fixed by logging the failure and droping the events. Other (unknown) errors in the event sending thread now cause a termination of the program in all cases, with some diagnostic messages.