Fix null and empty object comparison #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273
We found that if the VaultSecret without label, the corresponding k8s secret keeps updating because the two secrets labels are not the same. It's because existing k8s secret labels is null, however, the k8s secret labels generated from newSecretForCR is an empty object.
The generated k8s secret labels and annotations are directly inherited from the VaultSecret CR, so it does not require to loop it and copy it again.
Also, we fix the go-staticcheck warnings that