Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to install a version in asdf 0.7.* results in /** being moved to $ASDF_INSTALL_PATH #11

Closed
richin13 opened this issue Nov 24, 2020 · 0 comments · Fixed by #12
Closed
Assignees
Labels
bug Something isn't working

Comments

@richin13
Copy link
Owner

richin13 commented Nov 24, 2020

Description

As of now the plugin is not backwards compatible with asdf version 0.7.*.

From asdf-vm/asdf#765 (comment)

If you want your plugin to work with both versions of asdf (0.8.* and 0.7.*) check for the presence of the ASDF_DOWNLOAD_PATH environment variable, and if it is not set download the qt code in the bin/install callback, and if it is set then assume the bin/download script already downloaded it (sounds like you've already implemented bin/download properly).

Right now we're not checking for the existence of $ASDF_DOWNLOAD_PATH in bin/install and just assume it exists which results in the root folder being moved to $ASDF_INSTALL_PATH

@richin13 richin13 added the bug Something isn't working label Nov 24, 2020
@richin13 richin13 self-assigned this Nov 24, 2020
@richin13 richin13 linked a pull request Nov 24, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant