Fix deploy CI artifact lookup for squash merges - #649
Merged
Conversation
Deploy assumed merge commits and fell back to github.sha for single-parent squash merges, so it never found the PR's successful ci.yml web-publish artifact. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent
Agent: Cursor Composer
Summary
resolve-ci-runassumed merge commits (second parent = PR head). The repo squash-merges tomain, so single-parent commits fell back togithub.shaand never matched a successfulci.ymlrun.web-publishartifact as before.pull-requests: readso the Actions token can call that endpoint.docs/architecture/testing-policy.md.This unblocks deploy for recent main merges (including #648) once this lands; the fixed workflow runs on the merge push itself.
Testing
ffa4bbbresolves to PR headad797a94(CI run that builtweb-publish)dotnet restore/build/test— not applicable (workflow/docs only).cschanges)Legacy database checks
Issues
Relates to #593
Follow-up
After merge, confirm the Deploy workflow's
resolve-ci-runstep succeeds and post-deploy smoke goes green.Made with Cursor