Skip to content

Fix deploy CI artifact lookup for squash merges - #649

Merged
richardorchard merged 1 commit into
mainfrom
composer/fix-deploy-squash-resolve
Aug 13, 2026
Merged

Fix deploy CI artifact lookup for squash merges#649
richardorchard merged 1 commit into
mainfrom
composer/fix-deploy-squash-resolve

Conversation

@richardorchard

Copy link
Copy Markdown
Owner

Agent

Agent: Cursor Composer

Summary

  • Deploy's resolve-ci-run assumed merge commits (second parent = PR head). The repo squash-merges to main, so single-parent commits fell back to github.sha and never matched a successful ci.yml run.
  • For single-parent commits, resolve the associated PR head via the commits→pulls API, then reuse that PR's web-publish artifact as before.
  • Adds pull-requests: read so the Actions token can call that endpoint.
  • Clarifies the same behavior in docs/architecture/testing-policy.md.

This unblocks deploy for recent main merges (including #648) once this lands; the fixed workflow runs on the merge push itself.

Testing

  • Locally verified squash commit ffa4bbb resolves to PR head ad797a94 (CI run that built web-publish)
  • dotnet restore/build/test — not applicable (workflow/docs only)
  • Coverage gate — not applicable (no .cs changes)

Legacy database checks

  • Not required for this change

Issues

Relates to #593

Follow-up

After merge, confirm the Deploy workflow's resolve-ci-run step succeeds and post-deploy smoke goes green.

Made with Cursor

Deploy assumed merge commits and fell back to github.sha for single-parent squash merges, so it never found the PR's successful ci.yml web-publish artifact.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the agent:composer Pull request authored by the composer agent/tooling. label Aug 13, 2026
@richardorchard
richardorchard merged commit f1aaf5a into main Aug 13, 2026
16 checks passed
@richardorchard
richardorchard deleted the composer/fix-deploy-squash-resolve branch August 13, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:composer Pull request authored by the composer agent/tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant