Prevent displaying the post-installation message#44
Merged
richard67 merged 1 commit intorichard67:5.1-dev-fix-duplicate-postinstall-messagefrom Apr 1, 2024
Conversation
…ready integrated into the .htaccess file. -> new installation of 4.4.4
Owner
|
Hmm, I don't know when the condition is checked, but I know that the first thing which happens on update is to unpack the files from the zip. After that, the htaccess.txt is the one from 5.1, and that contains the pattern, and so the message will never be shown if not already being there from a pervious update from 4.4.3 to 4.4.4, where we do not have this condition. So at least it should be changed so it checks only the .htaccess file. And it should be added in 4.4-dev too, I think, so we are consistent when updating from 4.4.3 or older to 4.4.4 or from 4.4 or 5.0 to 5.1 |
richard67
reviewed
Apr 1, 2024
richard67
merged commit f4c69c7
into
richard67:5.1-dev-fix-duplicate-postinstall-message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent displaying the post-installation message if Brotli support already integrated into the .htaccess file.
-> new installation of 4.4.4