Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation #1

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Add initial implementation #1

merged 5 commits into from
Dec 27, 2024

Conversation

richard-gyiko
Copy link
Owner

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • .python-version: Language not supported
  • src/.gitignore: Language not supported
  • src/autogen_ext_mcp/tools/init.py: Evaluated as low risk
  • src/autogen_ext_mcp/tools/toolkit.py: Evaluated as low risk
  • samples/agent_chat.py: Evaluated as low risk
Comments suppressed due to low confidence (4)

src/autogen_ext_mcp/tools/adapter.py:79

  • [nitpick] The error message is repeated twice, which might be redundant and unclear. Consider simplifying it to 'MCP tool execution failed: {str(e)}'.
raise Exception(f"MCP tool execution failed: {str(e)}") from e

src/autogen_ext_mcp/tools/adapter.py:42

  • [nitpick] The variable name 'args_type' is ambiguous. It should be renamed to 'input_model' for better clarity.
args_type = create_model(tool.inputSchema)

src/autogen_ext_mcp/tools/adapter.py:49

  • Ensure that the 'run' method is covered by tests, as it handles the core functionality of executing the MCP tool.
async def run(self, args: BaseModel, cancellation_token: CancellationToken) -> Any:

.github/workflows/build.yaml:6

  • [nitpick] The job name 'uv-example' is not descriptive. It should be renamed to 'build-and-lint'.
uv-example:
@richard-gyiko richard-gyiko merged commit eac3954 into main Dec 27, 2024
1 check passed
@richard-gyiko richard-gyiko deleted the lib branch December 27, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant