Allow submitting coords/data as a tibble #128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will not change or break any existing behaviour but will work if the coordinates are submitted in a tibble.
I was trying to submit coordinates in a tibble and was getting an odd error which I traced to the utils script. Since tibble inherits from data.frame it was passing the first check but was then causing an error later since
x[,1]
on a tibble will return a single column tibble rather than the expected vector.All the tests pass but I didn't add any new ones as I couldn't see a way to do that without at least adding a development dependency on
{tibble}