Avoid overwriting rails db:* rake tasks #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfilej If there is another set of tasks that is needed, I think user-demand should drive that. Thank you for contributing! |
seancribbs
pushed a commit
that referenced
this pull request
Feb 13, 2013
Avoid overwriting rails db:* rake tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #312.
I started with the smallest step possible – removing the code that overrides the default
rake db:*tasks. After this change thedbnamespace only affects the database specified indatabase.yml, while theriaknamespace affects the riak clusters.Do you think there is value in introducing another set of tasks, that would work on both databases at the same time (basically bringing the old behavior back under a different namespace)?