Add SHELL env var, ADT_CONTAINER_ENGINE, and disable workspace trust#12
Merged
Conversation
- Add SHELL=/bin/bash to devfile env — defensive fix for VS Code terminal spawning issues when SHELL is not set (#11) - Add ADT_CONTAINER_ENGINE=podman for tox podman support - Disable workspace trust to reduce friction for lab participants Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHELL=/bin/bashto devfile env — defensive fix for VS Code terminal spawning issues when SHELL is not set in the container environment (VS Code terminal fails to spawn in DevSpaces workspace #11)ADT_CONTAINER_ENGINE=podmanfor tox podman support (from upstream fix: devspaces sudo support with correct UID and user setup ansible/ansible-dev-tools#735)security.workspace.trust.enabledto reduce friction for lab participantsTest plan
echo $SHELLreturns/bin/bashinside the workspaceADT_CONTAINER_ENGINE=podman)🤖 Generated with Claude Code