Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloseWorkflow() blocks when BuildWorkflowInput() is still running #13

Closed
vistart opened this issue Jun 28, 2024 · 0 comments
Closed

CloseWorkflow() blocks when BuildWorkflowInput() is still running #13

vistart opened this issue Jun 28, 2024 · 0 comments
Labels
bug Something isn't working simple.DAG All issues involving simple.DAG
Milestone
v1.0.2

Comments

@vistart
Copy link
Contributor

vistart commented Jun 28, 2024

When BuildWorkflowInput() is still running and not yet completed, executing CloseWorkflow() will be blocked.

test case: https://github.com/rhosocial/go-dag/actions/runs/9519834742/job/26243876897
@vistart vistart added bug Something isn't working simple.DAG All issues involving simple.DAG labels Jun 28, 2024
vistart added a commit that referenced this issue Jun 28, 2024
@vistart
[simple]try to solve #13.
316de32
@vistart vistart added this to the v1.0.2 milestone Jun 28, 2024
vistart added a commit that referenced this issue Jun 28, 2024
@vistart
[simple]try to solve #13.
951ec86
vistart added a commit that referenced this issue Jun 28, 2024
@vistart
[simple]try to solve #13.
4a12752
@vistart vistart closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working simple.DAG All issues involving simple.DAG
Projects
None yet
Milestone
v1.0.2
Development

No branches or pull requests
1 participant
@vistart