Generalize product metapackage detection for alternate builds#4
Open
Generalize product metapackage detection for alternate builds#4
Conversation
The system package detection was previously hardcoded to only recognize packages matching `mage-os/product-*-edition`. This change generalizes the regex to match any `mage-os/product-*` package, enabling support for alternate product metapackages like `mage-os/product-minimal`. - Update isSystemPackage() regex to match any mage-os/product-* package - Update getRequiredPhpVersion() to use isSystemPackage() instead of hardcoded package name - Add unit tests for isSystemPackage() with various package patterns - Update ProductMetadataTest to use proper mage-os package names https://claude.ai/code/session_01KVLKuTyatjiMtYp2npbqgc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system package detection was previously hardcoded to only recognize
packages matching
mage-os/product-*-edition. This change generalizesthe regex to match any
mage-os/product-*package, enabling support foralternate product metapackages like
mage-os/product-minimal.hardcoded package name
https://claude.ai/code/session_01KVLKuTyatjiMtYp2npbqgc