Make boot not required #5372
Closed
Make boot not required #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvykydal
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
rvykydal
force-pushed
the
make-boot-not-required
branch
from
654b9c5
to
4c52581
Compare
rvykydal
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
rvykydal
force-pushed
the
make-boot-not-required
branch
from
4c52581
to
3bd4deb
Compare
rvykydal
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
rvykydal
force-pushed
the
make-boot-not-required
branch
from
3bd4deb
to
ceb6fc4
Compare
rvykydal
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
M4rtinK
approved these changes
Dec 11, 2023
KKoukiou
approved these changes
Dec 12, 2023
|
/kickstart-test --testtype smoke |
vojtechtrefny
approved these changes
Dec 12, 2023
In general it is recommended to have a separate /boot, but not strictly required. In some cases it is required but we need to add API for that, because it depends mainly on the filesystem of the root partition. So now the requirement regards mainly biosboot and efi partitions, which is dependent on the platform. TODO: update tests
Add GetRecommendedMountPoints.
Instead of adding GetRecommendedMountPoints to GetRequiredMountpoints replace the both with a bit more generic GetMountPointConstraints that would add recommended/required flag to the constraints.
It is replaced by GetMountPointConstraints. GetRequiredMountPoints will be replaced after replacing it with GetMountPointConstraints in webui.
KKoukiou
force-pushed
the
make-boot-not-required
branch
from
ceb6fc4
to
0258c50
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
I've opened #5381 which does not break current webui (just adds the new API to be used). |
|
Handled in the #5381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the webui PR: rhinstaller/anaconda-webui#95
In the PR I was first adding
GetRecommendedMountPointsto the existingGetRequiredMountPointsbut in the end I am instesd adding more genericGetMountPointConstraintsthat would replace both of them (after merging the webui part which is replacing the API calls).