Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User screen review #5302

Merged
merged 2 commits into from
Nov 9, 2023
Merged

User screen review #5302

merged 2 commits into from
Nov 9, 2023

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Nov 7, 2023 •
edited
Loading

Addresses part of https://issues.redhat.com/browse/INSTALLER-3781

The pixel test sshots are showing the case without full user name.
For the full user name present:
Screenshot from 2023-11-07 13-37-12

@rvykydal
Copy link
Contributor Author

rvykydal commented Nov 7, 2023

/kickstart-test --waive webui-only

@rvykydal
Copy link
Contributor Author

rvykydal commented Nov 7, 2023

/webui-test

KKoukiou
KKoukiou approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge, I can rebase the split repo.

@rvykydal rvykydal merged commit 6f793d0 into rhinstaller:master Nov 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou approved these changes

Assignees
No one assigned
Labels
f40 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvykydal @KKoukiou