Master start ff earlier #5181

jkonecny12 · 2023-09-15T14:18:32Z

The execution time between Gnome Initial Setup and Anaconda is quite big
we need to reduce it by moving FF execution sooner before Anaconda is
executed.

Time to show Firefox window based on my measurements on VM with 2GB RAM
and 4vCPUs:
Original execution time: 13 seconds
With this commit: less than 6 seconds

If we want to reduce this time even more we need to do that in Firefox
or Gnome Shell (Gnome Initial Setup environment) somehow.

TODO:

Tests
Add JSX support so we don't have just white screen
~~[ ] Add event loop also to original webui-desktop script execution code?~~
- ~~This part is a question because I think we could have an issue without any event loop running but so far there are no complains about that...~~
- Let's do that in separate PR so we don't complicate things here. The code won't be used on Live anyway.
Make the code more robust to not crash on unexpected inputs

Resolves: rhbz#2236438

VladimirSlavik

Looks good to me. Thank you!

pyanaconda/ui/webui/__init__.py

jkonecny12 · 2023-09-22T13:29:55Z

/build-image --live

github-actions · 2023-09-22T13:58:31Z

Images built based on commit 99f06cd:

Live: failure

Download the images from the bottom of the job status page.

jkonecny12 · 2023-10-02T08:33:20Z

@KKoukiou I have to focus on other things, so if you want and have time please feel free to finish this PR. The backend solution should be ready we just need to found a way to avoid having white screen in FF before Anaconda backend is ready.

KKoukiou · 2023-10-09T09:39:32Z

pyanaconda/ui/webui/__init__.py

+    def _run_webui(self):
+        # FIXME: This part should be start event loop (could use the WatchProcesses class)
+        # FIXME: We probably want to move this to early execution similar to what we have on live
+        profile_name = FIREFOX_THEME_DEFAULT


The live vs boot.iso need different firefox theming. This is not a desired change.

It is just code move. This code should be started only on boot.iso not on live so the theme here is correct. The other theme is specified in liveinst script because there is a place where the script is started.

pyanaconda/ui/webui/__init__.py

KKoukiou · 2023-10-16T16:08:43Z

/build-image --live

github-actions · 2023-10-16T16:30:44Z

Images built based on commit 99f06cd:

Live: failure

Download the images from the bottom of the job status page.

pep8speaks · 2023-10-16T17:14:20Z

Hello @jkonecny12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/unit_tests/pyanaconda_tests/ui/test_webui.py:

Line 89:9: E303 too many blank lines (2)
Line 128:100: E501 line too long (106 > 99 characters)
Line 139:9: E303 too many blank lines (2)
Line 151:100: E501 line too long (106 > 99 characters)
Line 189:100: E501 line too long (100 > 99 characters)

Comment last updated at 2024-01-22 14:43:52 UTC

KKoukiou · 2023-10-16T17:15:07Z

Here is a screencast on the current behavior:

AwesomeScreenshot-10_16_2023.7.10.28PM.mp4

jkonecny12 · 2024-01-11T14:53:53Z

Updated with a new solution of a flag file signalizing that backend is ready to be consumed after Anaconda is initialized.

Web UI code was removed because it's in different repository now. @KKoukiou could you please help me there and link a PR here? The Web UI needs to wait until /run/anaconda/backend_ready is created.

jkonecny12 · 2024-01-11T14:54:06Z

/kickstart-test --testtype smoke

jkonecny12 · 2024-01-12T14:45:24Z

/packit build

jkonecny12 · 2024-01-16T10:21:58Z

/packit build

poncovka

LGTM

pyanaconda/ui/webui/__init__.py

data/liveinst/liveinst

jkonecny12 · 2024-01-17T15:29:48Z

Verified together with rhinstaller/anaconda-webui#132 and on a spin (KDE Live). Everything seems to be working fine with the current code.

jkonecny12 · 2024-01-17T15:37:27Z

/packit build

jkonecny12 · 2024-01-17T15:37:33Z

/kickstart-test --testtype smoke

jkonecny12 · 2024-01-17T15:52:04Z

Screecast
Kooha-2024-01-17-16-22-35.webm

Based on my measuring it seems to be faster almost by 50%.
Without this patch: 10 seconds
With this patch: 6 seconds

poncovka

LGTM

poncovka · 2024-01-18T15:41:44Z

data/liveinst/liveinst

 # Force the X11 backend since sudo and wayland do not mix
 export GDK_BACKEND=x11

 if [ -x /usr/bin/udisks ]; then
-    /usr/bin/udisks --inhibit -- "$ANACONDA" "$@"
+    /usr/bin/udisks --inhibit -- start_anaconda "$@"


Is it necessary to do the additional set up while inhibiting some of the udisks operations? I am not sure.

Based on the testing it should be fine. Also we inhibit the udisks for the whole Anaconda run if I'm reading this correctly which included start of the Firefox even before.

@vojtechtrefny do you have some recommendation for this?

This must be a very ancient check -- /usr/bin/udisks doesn't exists in udisks2, the old udisks package is still available in Fedora, but nobody is using it anymore (udisks 2.0 has been released 11 years ago). I think this can be safely removed.

CC @tbzatek

Well the surrounding check evaluates to FALSE anyway and was for some time already. So this can be safely removed.

If you still want to keep the inhibit, you need to to that via D-Bus call to UDisks (2). Unless you want to suspend the system in the middle of installation, I wouldn't worry about that much.

heh, ok. In that case let's remove it in separate PR because it doesn't seem related to this. Thanks for info.

And I don't think we need that inhibit, it seems it works fine now so we probably don't need that...

jkonecny12 · 2024-01-22T12:50:50Z

/packit build

rvykydal

Looks good to me.

The execution time between Gnome Initial Setup and Anaconda is quite big we need to reduce it by moving FF execution sooner before Anaconda is executed. Time to show Firefox window based on my measurements on VM with 2GB RAM and 4vCPUs: Original execution time: 13 seconds With this commit: less than 6 seconds If we want to reduce this time even more we need to do that in Firefox or Gnome Shell (Gnome Initial Setup environment) somehow. Resolves: rhbz#2236438

Currently Anaconda doesn't have DBus API to signalize that backend is ready to be consumed (initialized). For this reason Web UI don't know when it can access the Web UI. For this reason let's introduce a new flag file which is a signal for Web UI that loading screen could be closed and Anaconda is ready to be used. Resolves: rhbz#2236438

jkonecny12 · 2024-01-22T14:43:52Z

Rebased.

jkonecny12 · 2024-01-22T14:43:59Z

/kickstart-test --testtype smoke

jkonecny12 · 2024-01-22T17:18:25Z

Broken test is caused by COPR repository containing older a newer builds. 40.8 and 40.17 and trying to install both versions. Could be probably resolved by removing old builds.

jkonecny12 · 2024-01-22T22:47:13Z

I'm not able to resolve it because I don't have permission to remove the old builds. Merging anyway - not related to change.

github-actions bot added the f40 label Sep 15, 2023

jkonecny12 mentioned this pull request Sep 15, 2023

Start Firefox earlier on Live media #5152

Closed

3 tasks

VladimirSlavik approved these changes Sep 15, 2023

View reviewed changes

rvykydal approved these changes Sep 19, 2023

View reviewed changes

M4rtinK reviewed Sep 21, 2023

View reviewed changes

pyanaconda/ui/webui/__init__.py Outdated Show resolved Hide resolved

martinpitt mentioned this pull request Sep 23, 2023

Add script to download fedora 39 live ISO cockpit-project/bots#5241

Closed

1 task

KKoukiou reviewed Oct 9, 2023

View reviewed changes

KKoukiou force-pushed the master-start-ff-earlier branch from 99f06cd to 76d9f3e Compare October 16, 2023 17:14

KKoukiou marked this pull request as ready for review October 16, 2023 17:15

KKoukiou approved these changes Oct 16, 2023

View reviewed changes

jkonecny12 force-pushed the master-start-ff-earlier branch from 76d9f3e to e4a1d7b Compare January 11, 2024 14:51

jkonecny12 had a problem deploying to gh-cockpituous January 11, 2024 14:51 — with GitHub Actions Failure

poncovka reviewed Jan 16, 2024

View reviewed changes

pyanaconda/ui/webui/__init__.py Outdated Show resolved Hide resolved

pyanaconda/ui/webui/__init__.py Outdated Show resolved Hide resolved

poncovka reviewed Jan 16, 2024

View reviewed changes

data/liveinst/liveinst Show resolved Hide resolved

jkonecny12 force-pushed the master-start-ff-earlier branch from e4a1d7b to 929bf95 Compare January 17, 2024 13:32

jkonecny12 temporarily deployed to gh-cockpituous January 17, 2024 13:32 — with GitHub Actions Inactive

jkonecny12 force-pushed the master-start-ff-earlier branch from 929bf95 to 6b202f5 Compare January 17, 2024 13:54

jkonecny12 temporarily deployed to gh-cockpituous January 17, 2024 13:54 — with GitHub Actions Inactive

jkonecny12 mentioned this pull request Jan 17, 2024

Use flag file to get signaled when backend is ready rhinstaller/anaconda-webui#132

Merged

poncovka reviewed Jan 18, 2024

View reviewed changes

rvykydal approved these changes Jan 22, 2024

View reviewed changes

jkonecny12 added 2 commits January 22, 2024 15:43

jkonecny12 force-pushed the master-start-ff-earlier branch from 6b202f5 to bde33e7 Compare January 22, 2024 14:43

jkonecny12 temporarily deployed to gh-cockpituous January 22, 2024 14:43 — with GitHub Actions Inactive

jkonecny12 merged commit 3f68ee9 into rhinstaller:master Jan 22, 2024
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master start ff earlier #5181

Master start ff earlier #5181

jkonecny12 commented Sep 15, 2023 •

edited by KKoukiou

Loading

VladimirSlavik left a comment

jkonecny12 commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

jkonecny12 commented Oct 2, 2023

KKoukiou Oct 9, 2023

jkonecny12 Oct 11, 2023

KKoukiou commented Oct 16, 2023

github-actions bot commented Oct 16, 2023

pep8speaks commented Oct 16, 2023 •

edited

Loading

KKoukiou commented Oct 16, 2023

jkonecny12 commented Jan 11, 2024

jkonecny12 commented Jan 11, 2024

jkonecny12 commented Jan 12, 2024

jkonecny12 commented Jan 16, 2024

poncovka left a comment

jkonecny12 commented Jan 17, 2024

jkonecny12 commented Jan 17, 2024

jkonecny12 commented Jan 17, 2024

jkonecny12 commented Jan 17, 2024

poncovka left a comment

poncovka Jan 18, 2024

jkonecny12 Jan 22, 2024

vojtechtrefny Jan 22, 2024 •

edited

Loading

tbzatek Jan 22, 2024

jkonecny12 Jan 22, 2024

jkonecny12 commented Jan 22, 2024

rvykydal left a comment

jkonecny12 commented Jan 22, 2024

jkonecny12 commented Jan 22, 2024

jkonecny12 commented Jan 22, 2024

jkonecny12 commented Jan 22, 2024

Master start ff earlier #5181

Master start ff earlier #5181

Conversation

jkonecny12 commented Sep 15, 2023 • edited by KKoukiou Loading

VladimirSlavik left a comment

Choose a reason for hiding this comment

jkonecny12 commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

jkonecny12 commented Oct 2, 2023

KKoukiou Oct 9, 2023

Choose a reason for hiding this comment

jkonecny12 Oct 11, 2023

Choose a reason for hiding this comment

KKoukiou commented Oct 16, 2023

github-actions bot commented Oct 16, 2023

pep8speaks commented Oct 16, 2023 • edited Loading

Comment last updated at 2024-01-22 14:43:52 UTC

KKoukiou commented Oct 16, 2023

jkonecny12 commented Jan 11, 2024

jkonecny12 commented Jan 11, 2024

jkonecny12 commented Jan 12, 2024

jkonecny12 commented Jan 16, 2024

poncovka left a comment

Choose a reason for hiding this comment

jkonecny12 commented Jan 17, 2024

jkonecny12 commented Jan 17, 2024

jkonecny12 commented Jan 17, 2024

jkonecny12 commented Jan 17, 2024

poncovka left a comment

Choose a reason for hiding this comment

poncovka Jan 18, 2024

Choose a reason for hiding this comment

jkonecny12 Jan 22, 2024

Choose a reason for hiding this comment

vojtechtrefny Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

tbzatek Jan 22, 2024

Choose a reason for hiding this comment

jkonecny12 Jan 22, 2024

Choose a reason for hiding this comment

jkonecny12 commented Jan 22, 2024

rvykydal left a comment

Choose a reason for hiding this comment

jkonecny12 commented Jan 22, 2024

jkonecny12 commented Jan 22, 2024

jkonecny12 commented Jan 22, 2024

jkonecny12 commented Jan 22, 2024

jkonecny12 commented Sep 15, 2023 •

edited by KKoukiou

Loading

pep8speaks commented Oct 16, 2023 •

edited

Loading

vojtechtrefny Jan 22, 2024 •

edited

Loading