Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: Let error reporting dialog test area auto resize #5076

Merged
merged 1 commit into from
Aug 28, 2023
Merged

webui: Let error reporting dialog test area auto resize #5076

merged 1 commit into from
Aug 28, 2023

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Aug 24, 2023 •
edited
Loading

No description provided.

@KKoukiou KKoukiou marked this pull request as ready for review August 24, 2023 12:11
@rvykydal
Copy link
Contributor

rvykydal commented Aug 24, 2023 •
edited
Loading

I seem to be getting this using test/webui_testvm.py which is too small ?
Screenshot from 2023-08-24 14-08-43

@KKoukiou
Copy link
Contributor Author

@rvykydal you 're right - sorry - tested in a screen size that worked and though it was ok. re-checking.

rvykydal
rvykydal approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.
Looking at it the helper texts actually belongs logically to the button so it seems to be at the right place now.

@rvykydal
Copy link
Contributor

/kickstart-test --waive webui-only

@rvykydal rvykydal merged commit a7c5819 into rhinstaller:master Aug 28, 2023
16 checks passed
@rvykydal rvykydal mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvykydal rvykydal rvykydal approved these changes

Assignees
No one assigned
Labels
f39 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KKoukiou @rvykydal