Webui bz report offline #5075
Webui bz report offline #5075
Conversation
ui/webui/src/components/Error.jsx
Outdated
| @@ -127,7 +129,9 @@ export const BZReportModal = ({ | |||
| /> | |||
| <FormHelperText isHidden={false}> | |||
| <HelperText> | |||
| <HelperTextItem>{_("Reporting an issue will send information over the network. Plese review and edit the attached log to remove any sensitive information.")}</HelperTextItem> | |||
| {isConnected | |||
| ? <HelperTextItem> {_("Reporting an issue will send information over the network. Plese review and edit the attached log to remove any sensitive information.")} </HelperTextItem> | |||
There was a problem hiding this comment.
oops this exists upstream already.
There was a problem hiding this comment.
Regarding the icon you mentioned from https://react-icons.github.io/react-icons/search?q=offline this is a whole new librbary and not Patternfly. So I think we should stick to Patternfly available icons.
If some icons is missing there, report that upstream https://github.com/patternfly/patternfly-react/issues/
rvykydal
force-pushed
the
webui-bz-report-offline
branch
from
779d06e
to
11a3e0e
Compare
You are right, I was blind, it is among PF icons (https://www.patternfly.org/design-foundations/icons/). |
rvykydal
force-pushed
the
webui-bz-report-offline
branch
from
11a3e0e
to
d613150
Compare
|
/kickstart-test --waive webui-only |
|
I would suggest to add the tests in a separate issue. We need to think about alternatives:
|
|
Fedora bug report for Beta FE purposes: https://bugzilla.redhat.com/show_bug.cgi?id=2234964 |
rvykydal
force-pushed
the
webui-bz-report-offline
branch
from
d613150
to
c916fe9
Compare
|
/kickstart-test --waive webui-only |
| <HelperTextItem>{_("Reporting an issue will send information over the network. Plese review and edit the attached log to remove any sensitive information.")}</HelperTextItem> | ||
| {isConnected | ||
| ? <HelperTextItem> {_("Reporting an issue will send information over the network. Please review and edit the attached log to remove any sensitive information.")} </HelperTextItem> | ||
| : <HelperTextItem icon={<DisconnectedIcon />}> {_("Network not available. Configure the network in the top bar menu to report the issue.")} </HelperTextItem>} |
There was a problem hiding this comment.
I think this is good for now in the Fedora Workstation environment, but we should take a note to handle this somehow better for other environments. Eq. boot.iso currently does not have a top bar & other Live spins could have different mechanisms for this.
Addresses https://issues.redhat.com/browse/INSTALLER-3637
TODO:
Video:
https://rvykydal.fedorapeople.org/webui/error_handling/webui-bz-report-offline.webm
To check locally you can apply updates image in your live installation of some reasonably recent image in terminal by running: