Update goose to 1.38

[samdoran]

Here's the transcript from running the commands.

Summary by CodeRabbit

• New Features
  • Terminal UI support is enabled by default, with a build option to exclude the TUI subcommand.
• Bug Fixes
  • Improved native-tls compatibility by adjusting the security key handling library version.
  • Updated TLS crypto backend selection so different TLS stacks use the appropriate configuration.
• Chores
  • Enhanced portability by removing platform-specific dependency overrides and switching to system-library usage where applicable.
  • Updated packaging/release metadata for version 1.38.0.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Bumps the package version to 1.38.0, gates the tui CLI subcommand behind a Cargo feature flag, removes non-Linux dependency overrides, updates downstream Cargo default features to use native-tls and sqlite-unbundled, adds a pkcs8 downgrade patch for native-tls compatibility, and updates the RPM spec and changelog accordingly.

Changes

TUI Feature Flag

Layer / File(s)	Summary
TUI feature definition and module gating 0000-Add-tui-feature-flag-for-tui-command.patch	Adds empty tui feature to goose-cli manifest, enables it in default and portable-default, and conditionally compiles pub mod tui in commands/mod.rs.
TUI CLI subcommand and dispatch gating 0000-Add-tui-feature-flag-for-tui-command.patch	Wraps the Command::Tui clap declaration, command-name mapping, and handle_tui dispatch arm in #[cfg(feature = "tui")].

Linux-only Dependency and Feature Cleanup

Layer / File(s)	Summary
Strip non-Linux dependencies and workspace overrides 0001-Strip-non-Linux-deps-and-use-system-libraries.patch	Removes vendor/v8 workspace member, drops [patch.crates-io] overrides for v8 and cudaforge, removes root winapi, drops the vendored keyring feature, and deletes Windows/macOS-only dependency sections from goose-server and goose.
Downstream default Cargo features and SQLx 0002-Set-downstream-feature-flags.patch	Replaces goose-cli and goose-server defaults with native-tls, telemetry, otel, system-keyring, and disable-update; switches goose sqlx from sqlite to sqlite-unbundled.
pkcs8 downgrade for native-tls compatibility 0003-Downgrade-pkcs8-to-0.10.2-for-native-tls-compat.patch	Downgrades pkcs8 from 0.11.0 to 0.10.2 in crates/goose/Cargo.toml to restore native-tls compatibility.
rcgen TLS backend selection 0004-aws-lc-rs-feature-flag.patch	Changes goose-server TLS features to select rcgen/aws_lc_rs for rustls-tls and rcgen/ring for native-tls, updates rcgen defaults, and adds ring entries to Cargo.lock.

Release Packaging and Spec Updates

Layer / File(s)	Summary
RPM spec version, patch list, and license goose.spec, generate-vendor-tarball.sh	Bumps spec Version to 1.38.0, adds 0003 pkcs8 patch entry, renumbers patch section headers, removes 0000 patch from the vendoring PATCHES array, and expands license expressions to include MIT.
1.38.0-1 changelog entry changelog	Adds a new 1.38.0-1 release entry with a full bullet list of features and fixes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• rhel-lightspeed/goose#25: Directly modifies generate-vendor-tarball.sh PATCHES list and goose.spec patch numbering, the same files updated in this PR.

Suggested reviewers

• r0x0d

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the primary change: updating goose to version 1.38.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[samdoran]

Builds failed due to issue with our use of native-tis. I added another patch pinning pkcs8 to an older version to try and resolve this. I'm not sure if that's the correct approach. I would appreciate feedback.

[samdoran]

Oh, I see what needs to be done. Those patches are still used.

[samdoran]

I created a few smaller patch ranges to hold the types of patches. Hopefully that will make it easier to add/remove patches in the future without having to renumber everything.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@0004-aws-lc-rs-feature-flag.patch`:
- Line 1: The RPM build is pointing at a patch name that no longer matches the
file in the tree, so either rename `0004-aws-lc-rs-feature-flag.patch` to match
the existing `Patch4` entry in `goose.spec`, or update the `Patch4` reference in
`goose.spec` to use the current filename. Check the patch declaration in
`goose.spec` and the patch file name together so they stay consistent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6fa8fc26-9f6f-463d-abed-0669c7fa42af

📥 Commits

Reviewing files that changed from the base of the PR and between cfff020 and b934e72.

📒 Files selected for processing (3)

• 0004-aws-lc-rs-feature-flag.patch
• generate-vendor-tarball.sh
• goose.spec

✅ Files skipped from review due to trivial changes (1)

• generate-vendor-tarball.sh

🚧 Files skipped from review as they are similar to previous changes (1)

• goose.spec

[r0x0d]

I just updated the licenses, and we know the build works. I will just force-merge it to release o fedora.