Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow injecting layout HTMLs #269

Closed
wants to merge 1 commit into from
Closed

allow injecting layout HTMLs #269

wants to merge 1 commit into from

Conversation

undergroundwires
Copy link

Injectables to make the theme extensible without overwriting files

@undergroundwires
Copy link
Author

undergroundwires commented Dec 24, 2021

I can resolve the conflicts.

And also taking a second look at it, I see that extra-head.html got merged later on so we do not need to introduce something new for it. So I can remove that part.

We can then rename other one to extra-body.html to follow same convention. Then we would follow the same convention and this PR becomes only about being able to extend body without overriding it.

What do you think @rhazdon ?

Thank you again btw for this awesome theme and your great job at maintaining it. I've started seeing it more and more on web and 1.1K star is just a big success. Happy new year.

@undergroundwires
Copy link
Author

Just did it with #350, so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant