Skip to content

Fix resetting isHandleRequested in OPFSCoopSyncVFS #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhashimoto merged 1 commit into from
Apr 30, 2025
Merged

Fix resetting isHandleRequested in OPFSCoopSyncVFS #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/examples/OPFSCoopSyncVFS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ export class OPFSCoopSyncVFS extends FacadeVFS {
if (file.persistentFile.isHandleRequested) {
// Another connection wants the access handle.
this.#releaseAccessHandle(file);
this.isHandleRequested = false;
file.persistentFile.isHandleRequested = false;
Comment on lines 437 to +440
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Good catch! Moving the isHandleRequested reset to the file.persistentFile scope is the correct solution to prevent the infinite loop. This ensures that the state is correctly managed per file and not globally on the VFS.

No code suggestion needed.

}
file.persistentFile.isFileLocked = false;
}
Expand Down
Loading