Deprecate MMBN Names #5240
Merged
Deprecate MMBN Names #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkmnsnfrn
changed the title
pkmnsnfrn
added
type: documentation
AsparagusEduardo
previously requested changes
Aug 25, 2024
AsparagusEduardo
changed the title
|
Moved changelog note to the top and renamed PR |
AsparagusEduardo
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Note
For developers with custom UIs, they can:
PrependFontToFitandFONT_SMALL_NARROWERto get Game Freak names to work within their custom UIsDescription
Removes
HANDLE_EXPANDED_SPECIES_NAME,B_EXPANDED_TYPE_NAMES,B_EXPANDED_ABILITY_NAMES,B_EXPANDED_MOVE_NAMES,I_EXPANDED_ITEM_NAMES, and their associated macros.Details
Going forward, names will be implemented using the Official Game Freak names, building off the work from #4241 and #5101.
Testing
The functionality in this PR is based on the current default behavior of expansion. Further testing beyond compilation was not done.
Clean Branch
You can recreate this branch by applying a patch or pulling the repo. From a clean version of expansion's upcoming, you can either:
Patch
wget https://files.catbox.moe/i5pwpq.patch -O mmbn.patch ; git apply mmbn.patch ; rm mmbn.patchRepo
git remote add psf-expansion https://github.com/PokemonSanFran/pokeemerald-expansion/ ; git pull psf-expansion deprecateMMBNDiscord Contact Info
I am
pkmnsnfrnon Discord and I have started a discussion thread.4241 and 5101 also have a discussion thread, for reference