Round Tests #5196
Merged
Round Tests #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedara90
added
the
category: battle-tests
AsparagusEduardo
requested changes
Aug 18, 2024
|
Some readability suggestions, but also recommends checking all 4 move animations just in case |
Co-authored-by: Eduardo Quezada <[email protected]>
|
Applied suggestions |
AsparagusEduardo
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the move Round.
Description
Tests that other battlers that selected Round moves immediately after the first user of Round, both allies and foes.
Tests that the turn order doesn't change otherwise (no exhaustive)
Tests that the other usages of Round has doubled Base Power.
Tests that #5148 hasn't been fixed.
Feature(s) this PR does NOT handle:
#5148 isn't fixed by this PR, it simply implements tests for the move and the bugged behavior.
Discord contact info
hedara