Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect rounding when maxHP <16 #5183

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

hedara90
Copy link
Collaborator

Description

Added code to make maxHP / 16 round to 1 if 0 in several cases.
Weather damage, Ice Body healing and some AI calculations adjusted.
Wrote tests for weather damage.
Wrote 2 "TO_DO" tests found along the way.

Issue(s) that this PR fixes

#5180

Discord contact info

hedara

@hedara90 hedara90 added category: battle-mechanic Pertains to battle mechanics category: battle-ai Pertains to Battle Engine Upgrade's AI bugfix Bugfixes labels Aug 16, 2024
@AlexOn1ine AlexOn1ine merged commit b641c6f into rh-hideout:master Aug 16, 2024
1 check passed
@hedara90 hedara90 deleted the low-maxHP-weather branch August 17, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-ai Pertains to Battle Engine Upgrade's AI category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants