Fixed followers breaking for species IDs above 1535 #5179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsparagusEduardo
previously approved these changes
Aug 15, 2024
pkmnsnfrn
requested changes
Aug 15, 2024
hedara90
added
bugfix
pkmnsnfrn
approved these changes
Aug 15, 2024
Bassoonian
added
category: pokemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followers were breaking the game in different ways when trying to spawn a follower with species ID above 1535.
This is fixed by increasing
OBJ_EVENT_GFX_SPECIES_BITSfrom 11 to 12, which should last us for quite a while.Images
Before:
crash0001-0350.mp4
After:
fix1537.mp4
Issue(s) that this PR fixes
#5105
People who collaborated with me in this PR
@mrgriffin
@SarnPoke
Discord contact info
hedara