Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ice Face, implemented tests #5171

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

hedara90
Copy link
Collaborator

Fixed Ice Face not transforming Eiscue back into Ice Face form when it should.

Description

Redid the ShouldChangeFormInWeather function to reset the ability for Ice Face to proc when opponents set up weather.
Added Ice Face to the abilities that trigger on switch in.
Implemented all the TO_DO tests for Ice Face.

Images

20240814_22h16m25s_grim

Issue(s) that this PR fixes

#5150

Discord contact info

hedara

src/battle_util.c Outdated Show resolved Hide resolved
@hedara90 hedara90 marked this pull request as draft August 14, 2024 21:17
@AlexOn1ine AlexOn1ine self-assigned this Aug 14, 2024
@hedara90 hedara90 marked this pull request as ready for review August 15, 2024 10:54
@hedara90 hedara90 added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes labels Aug 15, 2024
@AlexOn1ine AlexOn1ine merged commit 45f10d7 into rh-hideout:master Aug 15, 2024
1 check passed
@hedara90 hedara90 deleted the ice-face-fix branch August 16, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants