-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds in-battle effect of Pickup, adds Harvest and Pickup tests #5170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, a couple minor test things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thx!
One minor thing. Usually new features go to upcoming and master is for bugfixes but that's fine. Just a heads up for the future.
Adds Harvest and Pickup tests. Modified G-Max Replenish test due to Munchlax picking up an item before G-Max Replenish is used.
Fixes RandomUniformExcept not being inclusive on the higher boundary.
Issue(s) that this PR fixes
Fixes #3355
Discord contact info
PhallenTree