Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some gen 9 move anims + fickle beam rework #5159

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

TheTrueSadfish
Copy link

@TheTrueSadfish TheTrueSadfish commented Aug 13, 2024

  • Added new animations for these moves: SPIN_OUT, MORTAL_SPIN, FILLET_AWAY, FLOWER_TRICK, MAKE_IT_RAIN, SHED_TAIL, HYPER_DRILL, TWIN_BEAM, COMEUPPANCE, BLOOD_MOON, FICKLE_BEAM, THUNDERCLAP, HARD_PRESS, DRAGON_CHEER, MALIGNANT_CHAIN

  • Fixed Raging Bull's animation to include the screen break like Brick Break

  • Changed Fickle Beam's effect to be like magnitude to include the battle message "is going all out for this attack"

also a save to test em all: pokeemerald.zip

purple chains by ogwon on discord
blood moon and red explosions by me (but they're just recolors lol)
beam by me/livra on discord

src/battle_script_commands.c Outdated Show resolved Hide resolved
src/battle_util.c Outdated Show resolved Hide resolved
@TheTrueSadfish TheTrueSadfish deleted the branch rh-hideout:master August 13, 2024 21:04
@TheTrueSadfish TheTrueSadfish deleted the master branch August 13, 2024 21:04
@TheTrueSadfish TheTrueSadfish restored the master branch August 13, 2024 21:05
@TheTrueSadfish TheTrueSadfish deleted the master branch August 13, 2024 21:06
@hedara90
Copy link
Collaborator

I'll look at the animation code tomorrow.
But looking at the animations in game they look good.
Just 2 comments about that.
pokeemerald-5
I think the spin anim sprite should use a more purple palette.
pokeemerald-4
Should the thunderbolt reach further down so it doesn't stop halfway down the sprite?

@TheTrueSadfish TheTrueSadfish restored the master branch August 13, 2024 21:11
@hedara90 hedara90 reopened this Aug 13, 2024
@hedara90 hedara90 added the category: move animation Pertains to move animations label Aug 13, 2024
@TheTrueSadfish
Copy link
Author

pokeemerald
pokeemerald1
these should hopefully look better

@hedara90
Copy link
Collaborator

pokeemerald-6
I meant more the spinny bits of Mortal Spin, here I just slapped ANIM_TAG_POISON_BUBBLE into the palette since it was already loaded.

Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style changes and comment on Hard Press

data/battle_anim_scripts.s Outdated Show resolved Hide resolved
data/battle_anim_scripts.s Outdated Show resolved Hide resolved
data/battle_anim_scripts.s Outdated Show resolved Hide resolved
data/battle_anim_scripts.s Outdated Show resolved Hide resolved
data/battle_anim_scripts.s Outdated Show resolved Hide resolved
data/battle_anim_scripts.s Outdated Show resolved Hide resolved
data/battle_anim_scripts.s Show resolved Hide resolved
data/battle_anim_scripts.s Show resolved Hide resolved
@TheTrueSadfish
Copy link
Author

mortalspin
did a blendparticle instead since i thought it looked nicer

@hedara90 hedara90 merged commit fde85e9 into rh-hideout:master Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: move animation Pertains to move animations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants