Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Zigzgoon battle being able to use a Gimmick #5129

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Fixes Zigzgoon battle being able to use a Gimmick #5129

merged 4 commits into from
Aug 10, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

Fixes Zigzaggon being able to Dynamax and Terastal on the first battle.

@AlexOn1ine
Copy link
Collaborator Author

I'm not sure if it makes sense to name BATTLE_TYPE_FIRST_BATTLE like that. It is only set for the Zigzagoon battle. So if you remove it it willl do nothing and might be confusing.

This could be a PR to pret but I don't know a better name, maybe BATTLE_TYPE_BIRCH_ZIGZAGOON?

@AlexOn1ine AlexOn1ine added the bugfix Bugfixes label Aug 10, 2024
AlexOn1ine
AlexOn1ine commented Aug 10, 2024
View reviewed changes
src/battle_dynamax.c Outdated Show resolved Hide resolved
AlexOn1ine
AlexOn1ine commented Aug 10, 2024
View reviewed changes
src/battle_terastal.c Outdated Show resolved Hide resolved
@Bassoonian Bassoonian added the category: battle-mechanic Pertains to battle mechanics label Aug 10, 2024
@Bassoonian
Copy link
Collaborator

I'm not sure if it makes sense to name BATTLE_TYPE_FIRST_BATTLE like that. It is only set for the Zigzagoon battle. So if you remove it it willl do nothing and might be confusing.

This could be a PR to pret but I don't know a better name, maybe BATTLE_TYPE_BIRCH_ZIGZAGOON?

I agree that a possible rename should be a pret PR instead. I assume FIRST_BATTLE was chosen for compatibility with RS which uses Poochyena instead? Worth discussing there I think

@Bassoonian Bassoonian merged commit 77afb01 into rh-hideout:master Aug 10, 2024
1 check passed
@Bassoonian Bassoonian mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bassoonian Bassoonian Bassoonian approved these changes

Assignees
No one assigned
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexOn1ine @Bassoonian