Follower palette fix #5107
Merged
Follower palette fix #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2024 13:25
tertu-m
approved these changes
Aug 6, 2024
Bassoonian
added
category: pokemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Palettes for some followers were broken.
Description
Padded all palettes to contain 16 colors.
Enabled shiny overworld palalettes where they were disabled.
Through testing I observed that palettes for followers contained garbage if the palettes either contained less than 16 defined colors, or a 'gShinyOverworldPalette` wasn't supplied to the species.
Images
Issue(s) that this PR fixes
Before:
After:
Testing, one color removed from
overworld_normal.palTesting,
gShinyOverworldPalettecommented out from species define.Feature(s) this PR does NOT handle:
Unown, I did not fix sprites and palette for the Unown letters
Discord contact info
hedara